build: def NODE_USE_NODE_CODE_CACHE only used in node_mksnapshot#63588
Merged
nodejs-github-bot merged 1 commit intoMay 28, 2026
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
legendecas
force-pushed
the
node_use_node_code_cache
branch
from
dc8150a to
4577d5e
Compare
juanarbol
approved these changes
May 26, 2026
lpinca
approved these changes
May 26, 2026
legendecas
added
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
joyeecheung
approved these changes
May 27, 2026
Collaborator
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 54f7e89 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NODE_USE_NODE_CODE_CACHEis only used innode_mksnapshot.cc. It is unnecessary to define it for targetlibnode.